Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): memory allocation in filtered spans #98

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix(go): memory allocation in filtered spans #98

merged 2 commits into from
Aug 21, 2023

Conversation

wikiwong
Copy link
Contributor

  • Give AdapterBase the ability to construct OTEL call spans (since this is industry standard and most common format)
  • Hoist (and sum) memory allocations to parent span when current span is being filtered

@wikiwong wikiwong changed the title fix(go): mem alloc filtered spans fix(go): memory allocation in filtered spans Aug 21, 2023
nilslice
nilslice approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wikiwong wikiwong merged commit a704dd2 into main Aug 21, 2023
6 checks passed
@wikiwong wikiwong deleted the fix-mem-alloc-filtered-spans branch August 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wikiwong @nilslice