Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightclient): don't expect signer #1463

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Nov 11, 2024

Solves arts testnet issue

Nov 11 15:09:41 ip-10-0-2-46 rollapp-evm[12691]: time="2024-11-11T15:09:41Z" level=error msg="Submit batch[startHeight 776661 endHeight 0x2aee4e0 error broadcast tx: rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 0: hook: after update state: validate optimistic: got cons state but no signer addr: client: 07-tendermint-44: h: 776660: internal [cosmossdk.io/[email protected]/errors.go:155] With gas wanted: '18446744073709551615' and gas used: '443375' : unknown request]" module=settlement_client

We shouldn't expect light client signers for consensus states from pre upgrade rollapps.

This PR just makes the file the same as it is in #1354, which also fixes the problem because there is no automatic forking there, and the signer isn't looked up

@danwt danwt requested a review from a team as a code owner November 11, 2024 15:44
@danwt danwt merged commit 1ee6efa into main Nov 11, 2024
5 checks passed
@danwt danwt deleted the danwt/dont-validate-signer-for-old-rollapps branch November 11, 2024 16:47
omritoptix pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants