Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollapp): store all rollapp revisions #1476

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 15, 2024

Description


Closes #1450

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Nov 15, 2024
@keruch keruch requested a review from a team as a code owner November 15, 2024 09:20
danwt
danwt previously approved these changes Nov 15, 2024
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean

x/rollapp/keeper/fraud_proposal.go Outdated Show resolved Hide resolved
x/rollapp/types/rollapp.go Show resolved Hide resolved
omritoptix
omritoptix previously approved these changes Nov 15, 2024
@keruch keruch dismissed stale reviews from omritoptix and danwt via 9f4a9fe November 15, 2024 12:08
danwt
danwt previously approved these changes Nov 15, 2024
mtsitrin
mtsitrin previously approved these changes Nov 15, 2024
@keruch keruch dismissed stale reviews from mtsitrin and danwt via fa83b5d November 15, 2024 12:31
@danwt danwt merged commit 4cad7dc into main Nov 18, 2024
5 checks passed
@danwt danwt deleted the kirill/1450-hard-fork-revisions branch November 18, 2024 11:21
danwt added a commit that referenced this pull request Nov 18, 2024
@omritoptix omritoptix restored the kirill/1450-hard-fork-revisions branch November 18, 2024 18:06
@omritoptix omritoptix deleted the kirill/1450-hard-fork-revisions branch November 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hard fork: refactor revision and revision_start_height to array
4 participants