Skip to content

Commit

Permalink
fix(docs): make submit loop comment more accurate re batch size (#852)
Browse files Browse the repository at this point in the history
  • Loading branch information
danwt authored and omritoptix committed May 18, 2024
1 parent e0bb19f commit 3cee247
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions block/submit.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,9 @@ func (m *Manager) SubmitLoop(ctx context.Context) {
}

/*
Note: since we dont explicitly coordinate changes to the accumulated size with actual batch creation
we don't have a guarantee that the accumulated size is the same as the actual batch size that will be made.
See https://github.com/dymensionxyz/dymint/issues/828
Until that is fixed, it's technically possibly to undercount, by having a some blocks be produced in between
setting the counter to 0, and actually producing the batch.
Note: since we dont explicitly coordinate changes to the accumulated size with actual batch creation
we don't have a guarantee that the accumulated size is the same as the actual batch size that will be made.
But the batch creation step will also check the size is OK, so it's not a problem.
*/
m.AccumulatedBatchSize.Store(0)

Expand Down

0 comments on commit 3cee247

Please sign in to comment.