simplify metric

dymensionxyz · May 13, 2024 · f290b86 · f290b86
1 parent 0facc1e
commit f290b86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/block/submit.go b/block/submit.go
@@ -139,7 +139,7 @@ func (m *Manager) HandleSubmissionTrigger() error {
 		return fmt.Errorf("sl client submit batch: start height: %d: inclusive end height: %d: %w", startHeight, actualEndHeight, err)
 	}
 
-	types.RollappHubHeightGauge.Set(float64(actualEndHeight)) // TODO(danwt): check
+	types.RollappHubHeightGauge.Set(float64(actualEndHeight))
 	m.LastSubmittedHeight = actualEndHeight
 	return nil
 }

diff --git a/block/synctarget.go b/block/synctarget.go
@@ -37,9 +37,9 @@ func (m *Manager) SyncToTargetHeightLoop(ctx context.Context) {
 				)
 				continue
 			}
+			types.RollappHubHeightGauge.Set(float64(h))
 			m.targetSyncHeight.Set(diodes.GenericDataType(&h))
 			m.logger.Info("Set new target sync height", "height", h)
-			types.RollappHubHeightGauge.Set(float64(h)) // TODO(danwt): needed?
 		case <-subscription.Cancelled():
 			m.logger.Info("syncTargetLoop subscription canceled")
 			return