Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: case-by-case ignore for gosec integer overflow #1226

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 12, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch requested a review from danwt November 12, 2024 15:44
@keruch keruch self-assigned this Nov 12, 2024
@keruch keruch requested a review from a team as a code owner November 12, 2024 15:44
@keruch keruch changed the base branch from main to kirill/header-time November 12, 2024 15:44
@keruch keruch changed the title Kirill/fix linter 1 chore: case-by-case ignore for gosec integer overflow Nov 12, 2024
Base automatically changed from kirill/header-time to main November 14, 2024 15:31
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind faith

@srene srene merged commit 5c2f6f8 into main Nov 22, 2024
4 checks passed
@srene srene deleted the kirill/fix-linter-1 branch November 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants