feat(fraud): extend fraud information upon detection #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymint into srene/hardfork-fix
…ymint into srene/hardfork-fix
Co-authored-by: Sergi Rene <[email protected]>
…crease-fraud-information
mtsitrin
reviewed
Nov 19, 2024
types/errors.go
Outdated
| } | ||
|
|
||
| func NewErrInvalidHeaderDataHashFraud(expected [32]byte, actual [32]byte) error { | ||
| func NewErrInvalidHeaderDataHashFraud(expected [32]byte, actual [32]byte, header Header) error { | ||
| return &ErrInvalidHeaderDataHashFraud{ | ||
| Expected: expected, |
There was a problem hiding this comment.
actual is redundant. same as header.DataHash
types/errors.go
Outdated
| Proposer []byte | ||
| } | ||
|
|
||
| // NewErrFraudAppHashMismatch creates a new ErrFraudAppHashMismatch error. | ||
| func NewErrFraudAppHashMismatch(expected [32]byte, actual [32]byte, block *Block) error { | ||
| func NewErrFraudAppHashMismatch(expected [32]byte, block *Block) error { |
There was a problem hiding this comment.
can use Header instead of Block
types/errors.go
Outdated
| @@ -38,10 +38,12 @@ type ErrFraudHeightMismatch struct { | |||
| } | |||
|
|
|||
| // NewErrFraudHeightMismatch creates a new ErrFraudHeightMismatch error. | |||
| func NewErrFraudHeightMismatch(expected uint64, actual uint64, block *Block) error { | |||
| func NewErrFraudHeightMismatch(expected uint64, block *Block) error { | |||
There was a problem hiding this comment.
can use Header instead of Block
types/errors.go
Outdated
| @@ -91,8 +99,10 @@ type ErrLastResultsHashMismatch struct { | |||
| // NewErrLastResultsHashMismatch creates a new ErrLastResultsHashMismatch error. | |||
| func NewErrLastResultsHashMismatch(expected [32]byte, block *Block) error { | |||
There was a problem hiding this comment.
can use Header instead of Block
omritoptix
changed the title
omritoptix
changed the title
omritoptix
approved these changes
Nov 19, 2024
mtsitrin
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1156
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: