Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequencers): make sequencer set updates interval configurable #1243

Merged

Conversation

artemijspavlovs
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner November 19, 2024 12:06
config/config.go Outdated Show resolved Hide resolved
@omritoptix
Copy link
Contributor

@artemijspavlovs build failed

omritoptix
omritoptix previously approved these changes Nov 19, 2024
@omritoptix omritoptix changed the title chore: retrieve sequencer update interval from config feat(sequencers): make sequencer update set interval configurable Nov 19, 2024
@omritoptix omritoptix changed the title feat(sequencers): make sequencer update set interval configurable feat(sequencers): make sequencer set updates interval configurable Nov 19, 2024
@omritoptix omritoptix merged commit 82f60ad into main Nov 19, 2024
4 checks passed
@omritoptix omritoptix deleted the artemijspavlovs/retrieve-sequencer-shange-interval-from-config branch November 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants