Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rotation): fixed race condition for last block #1244

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Nov 19, 2024 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as ready for review November 19, 2024 19:17
@mtsitrin mtsitrin requested a review from a team as a code owner November 19, 2024 19:17
@mtsitrin mtsitrin requested review from omritoptix and srene November 20, 2024 08:26
@mtsitrin mtsitrin requested a review from srene November 20, 2024 13:25
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why removing ctx.Err()?

@mtsitrin
Copy link
Contributor Author

Just curious why removing ctx.Err()?

  • it's clearer in regard of the errgroup. we'll have a single root error, otherwise each loop will add it's error
  • it's makes more sense. if your context got canceled it's graceful shutdown. shouldn't return error unless u have one

srene
srene previously approved these changes Nov 21, 2024
@danwt
Copy link
Contributor

danwt commented Nov 22, 2024

I just did a quick scan tbh

@srene srene merged commit a1be6f2 into main Nov 22, 2024
4 checks passed
@srene srene deleted the mtsitrin/1236-err-when-createandpostlastbatch branch November 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

err when CreateAndPostLastBatch
3 participants