Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (rollapp): register balances l2 #1247

Merged
merged 134 commits into from
Nov 22, 2024
Merged

feat (rollapp): register balances l2 #1247

merged 134 commits into from
Nov 22, 2024

Conversation

faultytolly
Copy link
Contributor

@faultytolly faultytolly commented Nov 20, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1138

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@faultytolly
Copy link
Contributor Author

this needs also

dymensionxyz/cosmosclient#37

@faultytolly faultytolly marked this pull request as ready for review November 21, 2024 09:06
@faultytolly faultytolly requested a review from a team as a code owner November 21, 2024 09:06
@keruch keruch self-requested a review November 21, 2024 14:50
Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter fails, and some comments from the previous review left

Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@srene srene merged commit cf2976a into main Nov 22, 2024
4 checks passed
@srene srene deleted the feat/register-balances-l2 branch November 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add celestia and dym account/balance to prometheus metrics
4 participants