Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): validate blocks revision when submit #1261

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Nov 29, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner November 29, 2024 08:51
@srene srene self-assigned this Nov 29, 2024
@srene srene marked this pull request as draft November 29, 2024 08:52
@srene srene changed the title fix(fork): instruction file roller + validate blocks revision when submit fix(manager): validate blocks revision when submit Nov 29, 2024
@srene srene marked this pull request as ready for review November 29, 2024 11:03
@srene srene changed the base branch from srene/1235-blocksync-revision to main November 29, 2024 11:14
@srene srene changed the base branch from main to srene/1235-blocksync-revision November 29, 2024 11:15
block/submit.go Outdated Show resolved Hide resolved
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one small code suggestion

@srene srene merged commit 8e19195 into srene/1235-blocksync-revision Nov 29, 2024
4 checks passed
@srene srene deleted the srene/revision-fix branch November 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants