feat(upgrade): move drs check to begin blocker to allow time-based upgrades #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
approved these changes
Dec 10, 2024
mtsitrin
reviewed
Dec 10, 2024
| @@ -375,14 +374,6 @@ func (m *Manager) UpdateTargetHeight(h uint64) { | |||
|
|
|||
| // ValidateConfigWithRollappParams checks the configuration params are consistent with the params in the dymint state (e.g. DA and version) | |||
| func (m *Manager) ValidateConfigWithRollappParams() error { | |||
| drsVersion, err := version.GetDRSVersion() | |||
There was a problem hiding this comment.
where it's gonna be validated now?
if the DRS changed in the rollapp params (through the RDK)
where it's validated against local version?
There was a problem hiding this comment.
its validated in the begin blocker function of the app dymensionxyz/rollapp-evm#393. this way it allows using a different version when upgrade is required, but if using wrong version it will fail in begin blocker
mtsitrin
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
This PR goes with with dymensionxyz/rollapp-evm#393
where drs rollapp param validation is moved to the begin blocker function to be aligned with upgrade flow, otherwise its not possible to run a new version (it will fail in dymint validation) before the drs is updated in the upgrade handler.
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1271
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: