Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drs): only send consensus msgs for drs upgrade when necessary #1277

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Dec 11, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner December 11, 2024 11:25
@srene srene marked this pull request as draft December 11, 2024 11:25
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 17.22%. Comparing base (ed72d9b) to head (9c5c819).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
block/fork.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
- Coverage   17.72%   17.22%   -0.51%     
==========================================
  Files         187      193       +6     
  Lines       55555    58740    +3185     
==========================================
+ Hits         9849    10116     +267     
- Misses      44182    47042    +2860     
- Partials     1524     1582      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srene srene self-assigned this Dec 11, 2024
@srene srene marked this pull request as ready for review December 13, 2024 11:09
@omritoptix omritoptix merged commit 2a07ba3 into main Dec 13, 2024
5 of 7 checks passed
@omritoptix omritoptix deleted the srene/refactor-drs-upgrade branch December 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants