Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hub dependency importing pseudo version of osmosis #627

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 4, 2024

update dymension/v3 import

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.04%. Comparing base (1ba1a39) to head (76bb88a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   44.02%   44.04%   +0.02%     
==========================================
  Files         119      120       +1     
  Lines       16414    16531     +117     
==========================================
+ Hits         7226     7281      +55     
- Misses       8164     8219      +55     
- Partials     1024     1031       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin marked this pull request as ready for review April 4, 2024 06:31
@mtsitrin mtsitrin requested a review from a team as a code owner April 4, 2024 06:31
@omritoptix omritoptix merged commit d609ad8 into main Apr 6, 2024
6 checks passed
@omritoptix omritoptix deleted the mtsitrin/619-remove-hub-dependency-importing-pseudo-version-of-osmosis branch April 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hub dependency importing pseudo version of osmosis
3 participants