Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: rename local hub settlement to local instead of mock #628

Merged

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 4, 2024

to avoid compatibility issues, I've left it as "mock" in the configuration files.

On the source code, the local hub and local da are now called local instead of mock.

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 44.04%. Comparing base (9733e1c) to head (c042bc0).

Files Patch % Lines
da/celestia/mock/server.go 0.00% 6 Missing ⚠️
da/grpc/mockserv/mockserv.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   44.04%   44.04%           
=======================================
  Files         120      120           
  Lines       16531    16531           
=======================================
  Hits         7281     7281           
  Misses       8219     8219           
  Partials     1031     1031           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin marked this pull request as ready for review April 4, 2024 09:36
@mtsitrin mtsitrin requested a review from a team as a code owner April 4, 2024 09:36
@mtsitrin mtsitrin self-assigned this Apr 4, 2024
@mtsitrin mtsitrin requested review from omritoptix and zale144 April 4, 2024 09:37
@mtsitrin mtsitrin merged commit 6406c2e into main Apr 6, 2024
5 of 6 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/625-rename-local-hub-setup-to-local-instead-of-mock branch April 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename local hub setup to local instead of mock
3 participants