Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move logger interface to types #633

Merged
merged 11 commits into from
Apr 8, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 6, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Apr 6, 2024 that may be closed by this pull request
source blockSource
daHeight uint64
}

// Manager is responsible for aggregating transactions into blocks.
type Manager struct {
Copy link
Contributor Author

@mtsitrin mtsitrin Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here is that syncCache removed as it's not used.
grouping and comments other than that

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 71.25000% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 44.05%. Comparing base (6406c2e) to head (a4fda42).
Report is 1 commits behind head on main.

❗ Current head a4fda42 differs from pull request most recent head 6823fe8. Consider uploading reports for the commit 6823fe8 to get more accurate results

Files Patch % Lines
settlement/dymension/dymension.go 65.45% 13 Missing and 6 partials ⚠️
settlement/grpc/grpc.go 0.00% 2 Missing ⚠️
da/celestia/mock/server.go 0.00% 1 Missing ⚠️
da/grpc/grpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   44.04%   44.05%           
=======================================
  Files         120      120           
  Lines       16531    16549   +18     
=======================================
+ Hits         7281     7290    +9     
- Misses       8219     8224    +5     
- Partials     1031     1035    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin changed the base branch from main to mtsitrin/551-retries-for-hub-client April 6, 2024 17:44
@mtsitrin mtsitrin marked this pull request as ready for review April 7, 2024 11:46
@mtsitrin mtsitrin requested a review from a team as a code owner April 7, 2024 11:46
danwt
danwt previously approved these changes Apr 8, 2024
Base automatically changed from mtsitrin/551-retries-for-hub-client to main April 8, 2024 12:02
@mtsitrin mtsitrin dismissed danwt’s stale review April 8, 2024 12:02

The base branch was changed.

@mtsitrin mtsitrin requested a review from danwt April 8, 2024 12:06
@mtsitrin mtsitrin merged commit 3cd61e0 into main Apr 8, 2024
4 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/632-refactor-move-logger-interface-to-types branch April 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: move Logger interface to types
2 participants