refactor: move executer to block package #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c534d1d.
…refactor-move-logger-interface-to-types
mtsitrin
commented
Apr 7, 2024
|
|
||
| err := m.applyBlock(ctx, prevCachedBlock, m.prevCommit[m.store.Height()+1], blockMetaData{source: gossipedBlock}) |
There was a problem hiding this comment.
bug fixed as commit cache not checked
mtsitrin
changed the base branch from
main
to
mtsitrin/632-refactor-move-logger-interface-to-types
mtsitrin
commented
Apr 7, 2024
| if block.Header.Height != m.store.Height()+1 { | ||
| // We crashed after the commit and before updating the store height. | ||
| m.logger.Error("Block not applied. Wrong height", "block height", block.Header.Height, "store height", m.store.Height()) | ||
| return nil |
There was a problem hiding this comment.
fixed bug when applying cache, as no error is returned but expected
danwt
requested changes
Apr 8, 2024
Base automatically changed from
mtsitrin/632-refactor-move-logger-interface-to-types
to
main
April 8, 2024 14:49
danwt
requested changes
Apr 15, 2024
block/manager.go
Outdated
Comment on lines
42
to
43
| executor *BlockExecutor | ||
|
|
There was a problem hiding this comment.
what do you think @mtsitrin ?
danwt
previously approved these changes
Apr 15, 2024
zale144
requested changes
Apr 15, 2024
block/executor.go
Outdated
| @@ -38,13 +36,13 @@ type BlockExecutor struct { | |||
|
|
|||
| // NewBlockExecutor creates new instance of BlockExecutor. | |||
| // Proposer address and namespace ID will be used in all newly created blocks. | |||
| func NewBlockExecutor(proposerAddress []byte, namespaceID string, chainID string, mempool mempool.Mempool, proxyApp proxy.AppConns, eventBus *tmtypes.EventBus, logger types.Logger) (*BlockExecutor, error) { | |||
| func NewBlockExecutor(proposerAddress []byte, namespaceID string, chainID string, mempool mempool.Mempool, proxyApp proxy.AppConns, eventBus *tmtypes.EventBus, logger types.Logger) (*Executor, error) { | |||
There was a problem hiding this comment.
Suggested change
| func NewBlockExecutor(proposerAddress []byte, namespaceID string, chainID string, mempool mempool.Mempool, proxyApp proxy.AppConns, eventBus *tmtypes.EventBus, logger types.Logger) (*Executor, error) { | |
| func NewExecutor(proposerAddress []byte, namespaceID string, chainID string, mempool mempool.Mempool, proxyApp proxy.AppConns, eventBus *tmtypes.EventBus, logger types.Logger) (*Executor, error) { |
Co-authored-by: zale144 <[email protected]>
danwt
approved these changes
Apr 16, 2024
mtsitrin
deleted the
mtsitrin/635-refactor-move-executer-to-block-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR handles few refactors:
executorcode from thestatepackage to theblockpackagem.store.NextHeight()instead ofm.store.Height()+1throughout the codestate.IsGenesis()to detect genesis runbesides,
fixed 2 bug. noted by comments
PR Standards
Opening a pull request should be able to meet the following requirements
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: