Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register nodeHealthStatusHandler for sequencer #683

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Apr 15, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #667

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this Apr 15, 2024
@zale144 zale144 requested a review from a team as a code owner April 15, 2024 10:39
go utils.SubscribeAndHandleEvents(ctx, m.pubsub, "nodeHealthStatusHandler", events.EventQueryHealthStatus, m.healthStatusEventCallback, m.logger)
if !isAggregator {
if isAggregator {
go utils.SubscribeAndHandleEvents(ctx, m.pubsub, "nodeHealthStatusHandler", events.EventQueryHealthStatus, m.healthStatusEventCallback, m.logger)

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
mtsitrin
mtsitrin previously approved these changes Apr 15, 2024
omritoptix
omritoptix previously approved these changes Apr 15, 2024
@omritoptix
Copy link
Contributor

@zale144 confilicts

@zale144 zale144 dismissed stale reviews from omritoptix and mtsitrin via f84fff2 April 15, 2024 16:09
@mtsitrin mtsitrin merged commit da2ff94 into main Apr 15, 2024
4 checks passed
@mtsitrin mtsitrin deleted the zale144/667-fix-non-sequencer-register-health-events branch April 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-sequencer nodes unnecessarily register health status event listener
3 participants