Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concurrency): remove unused sync cond #706

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 17, 2024

This thing was useless, AFAIU

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner April 17, 2024 12:19
@mtsitrin
Copy link
Contributor

I think the entire snippet can be removed

// Check if after we sync we are synced or a new syncTarget was already set.
// If we are synced then signal all goroutines waiting on isSyncedCond.
if m.store.Height() >= m.syncTarget.Load() {
    m.logger.Info("Synced at height", "height", m.store.Height())
    m.isSyncedCond.L.Lock()
    m.isSyncedCond.Signal()
    m.isSyncedCond.L.Unlock()
}

wdyt

@mtsitrin mtsitrin merged commit 5f325e5 into main Apr 18, 2024
4 checks passed
@mtsitrin mtsitrin deleted the danwt/delete-unused-cond branch April 18, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants