fix(p2p): validate block before applying and not before caching in p2p gossiping #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
reviewed
Apr 26, 2024
| @@ -130,8 +130,12 @@ func (m *Manager) attemptApplyCachedBlocks() error { | |||
| if !blockExists { | |||
| break | |||
| } | |||
| if err := m.validateBlock(cachedBlock.Block, cachedBlock.Commit); err != nil { | |||
There was a problem hiding this comment.
thinking we should delete it and not keep it in cache.
There was a problem hiding this comment.
block deleted from cache if invalid.
omritoptix
approved these changes
Apr 26, 2024
omritoptix
approved these changes
Apr 26, 2024
12 tasks
danwt
reviewed
Apr 27, 2024
danwt
reviewed
Apr 27, 2024
| if err := m.validateBlock(cachedBlock.Block, cachedBlock.Commit); err != nil { | ||
| delete(m.blockCache, cachedBlock.Block.Header.Height) | ||
| /// TODO: can we take an action here such as dropping the peer / reducing their reputation? | ||
| return fmt.Errorf("block not valid at height %d, dropping it: err:%w", cachedBlock.Block.Header.Height, err) |
There was a problem hiding this comment.
height should go at the end
don't need 'err'
|
see audit issue #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
P2P gossiping tries to validate blocks on reception. However, the validation fails if blocks are received unordered, dropping them, and being unable to sync using p2p for any block received after. This PR fixes the issue validating blocks in order, moving the validation call after caching them, and before applying, once all blocks are received and can be applied in order.
Opening a pull request should be able to meet the following requirements
Close #722
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: