Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(produce loop): handle unauthenticated error in settlement layer #726

Merged
merged 13 commits into from
Apr 28, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 27, 2024

PR Standards

Note: over time I intend to follow up this PR with more cleanups, and more usage of gerr packge

Opening a pull request should be able to meet the following requirements


Close #725

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner April 27, 2024 17:31
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@omritoptix omritoptix merged commit 33e78d1 into main Apr 28, 2024
3 of 5 checks passed
@omritoptix omritoptix deleted the danwt/725-emit-unhealth-in-extra-csae branch April 28, 2024 10:06
omritoptix pushed a commit that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settlement key error doesn't emit unhealthy event
2 participants