Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2p): validating gossiped block is created by the proposer #737

Merged
merged 8 commits into from
May 5, 2024
Merged

fix(p2p): validating gossiped block is created by the proposer #737

merged 8 commits into from
May 5, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Apr 29, 2024

PR Standards

This PR adds a validation upon received gossiped block, to avoid propagating blocks are not created by the proposer.

Opening a pull request should be able to meet the following requirements

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner April 29, 2024 22:47
@srene srene self-assigned this Apr 29, 2024
danwt
danwt previously approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mtsitrin
mtsitrin reviewed May 2, 2024
View reviewed changes
p2p/events.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin merged commit 851b312 into main May 5, 2024
3 of 5 checks passed
@mtsitrin mtsitrin deleted the srene/656-gossiped-block-validation branch May 5, 2024 07:16
@srene srene linked an issue May 6, 2024 that may be closed by this pull request
Invalid blocks can be received via p2p gossip #656
Closed
@srene srene mentioned this pull request May 6, 2024
Closed
omritoptix pushed a commit that referenced this pull request May 18, 2024
@srene @mtsitrin @omritoptix
fix(p2p): validating gossiped block is created by the proposer (#737)
4a0b80d 
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Michael Tsitrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

@danwt danwt danwt left review comments

Assignees

@srene srene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid blocks can be received via p2p gossip
3 participants
@srene @danwt @mtsitrin