Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): nil panic in rpc/json/handler.go WriteError #750

Merged
merged 6 commits into from
May 1, 2024
Merged

fix(rpc): nil panic in rpc/json/handler.go WriteError #750

merged 6 commits into from
May 1, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented May 1, 2024 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

Close #751

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this May 1, 2024
@zale144 zale144 requested a review from a team as a code owner May 1, 2024 12:18
@zale144 zale144 changed the title Fix nil panic in rpc/json/handler.go WriteError fix(rpc): nil panic in rpc/json/handler.go WriteError May 1, 2024
danwt
danwt requested changes May 1, 2024
View reviewed changes
rpc/json/handler.go Outdated Show resolved Hide resolved
@zale144 zale144 requested a review from danwt May 1, 2024 12:33
danwt
danwt approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@omritoptix omritoptix merged commit e09709b into main May 1, 2024
@omritoptix omritoptix deleted the zale144/fix-panic-in-WriteError branch May 1, 2024 16:32
omritoptix pushed a commit that referenced this pull request May 1, 2024
@zale144 @omritoptix
fix(rpc): nil panic in rpc/json/handler.go WriteError (#750)
365f33b 
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorTrustyDev VictorTrustyDev VictorTrustyDev approved these changes

@danwt danwt danwt approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees

@zale144 zale144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Found a nil pointer panic in rpc/json/handler.go
4 participants
@zale144 @omritoptix @danwt @VictorTrustyDev