fix(p2p): avoid receiving duplicated blocks

[srene]

PR Standards

This PR is aimed at preventing the reception of duplicated blocks from p2p network, by updating Gossipsub router configuration. It also prevents adding blocks to cache when already received. This improves performance and syncing times, because receiving too many packets from p2p may block applying blocks received from DA.

Opening a pull request should be able to meet the following requirements

---

Close #795 #803
<-- Briefly describe the content of this pull request -->

For Author:

• Targeted PR against correct branch
• included the correct type prefix in the PR title
• Linked to Github issue with discussion and accepted design
• Targets only one github issue
• Wrote unit and integration tests
• All CI checks have passed
• Added relevant godoc comments

---

For Reviewer:

• confirmed the correct type prefix in the PR title
• Reviewers assigned
• confirmed all author checklist items have been addressed

---

After reviewer approval:

• In case targets main branch, PR should be squashed and merged.
• In case PR targets a release branch, PR should be rebased.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.83%. Comparing base (851b312) to head (a4c4ae8).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
- Coverage   40.44%   39.83%   -0.62%     
==========================================
  Files         120      118       -2     
  Lines       18935    18740     -195     
==========================================
- Hits         7659     7465     -194     
- Misses      10201    10226      +25     
+ Partials     1075     1049      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danwt]

not sure if I understood what is the point of this pr?
There was too much demand for the mutex before?

[srene]

not sure if I understood what is the point of this pr? There was too much demand for the mutex before?

it avoids receiving extra duplicates from gossipsub protocol by passing extra options in p2p/client.go, this reduces the demand of the mutex. also it avoids adding already received blocks to the cache, in case it happens.

[mtsitrin]

can u explain this 1 year time? previously u had
time.Duration(int(c.blockTime.Nanoseconds()*int64(c.conf.GossipCacheSize))))

[srene]

i removed the ttl option and replaced gossipsub version with a new version where seen packets are not expiring

[danwt]

nice!

[omritoptix]

@mtsitrin can we merge?