Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): remove availability checks from retriever #835

Merged
merged 1 commit into from
May 12, 2024
Merged

feat(p2p): remove availability checks from retriever #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions block/retriever.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,7 @@ func (m *Manager) fetchBatch(daMetaData *da.DASubmitMetaData) da.ResultRetrieveB
},
}
}
// Check batch availability
availabilityRes := m.Retriever.CheckBatchAvailability(daMetaData)
if availabilityRes.Code != da.StatusSuccess {
return da.ResultRetrieveBatch{
BaseResult: da.BaseResult{
Code: da.StatusError,
Message: fmt.Sprintf("Error fetching batch: %s", availabilityRes.Message),
Error: availabilityRes.Error,
},
}
}

// batchRes.MetaData includes proofs necessary to open disputes with the Hub
batchRes := m.Retriever.RetrieveBatches(daMetaData)
// TODO(srene) : for invalid transactions there is no specific error code since it will need to be validated somewhere else for fraud proving.
Expand Down
Loading