Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to mtsitrin/324: simplify empty timing #836

Conversation

danwt
Copy link
Contributor

@danwt danwt commented May 9, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner May 9, 2024 13:10
block/produce.go Fixed Show fixed Hide fixed
block/produce.go Dismissed Show dismissed Hide dismissed
block/produce.go Dismissed Show dismissed Hide dismissed
block/produce.go Fixed Show fixed Hide fixed
block/produce.go Fixed Show fixed Hide fixed
block/produce.go Dismissed Show dismissed Hide dismissed
@mtsitrin mtsitrin merged commit 6454765 into mtsitrin/324-block-batch-submission-should-be-only-determined-by-max-bytes-or-max-hub-blocks May 9, 2024
4 checks passed
@mtsitrin mtsitrin deleted the danwt/patch-9-for-mtsitrin/324 branch May 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants