feat(p2p): add command to show p2p status #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested changes
May 9, 2024
cmd/dymint/commands/show_p2p_info.go
Outdated
Comment on lines
101
to
105
| duration, err := strconv.ParseInt(status["Duration"].(string), 10, 64) | ||
| if err != nil { | ||
| fmt.Println("Error parsing connection duration:", err) | ||
| } | ||
| fmt.Printf("Peer %d Id:%s Multiaddress:%s Duration:%s\n", i, info["id"], peer["remote_ip"], time.Duration(duration)) |
There was a problem hiding this comment.
what unit is the duration in ?
There was a problem hiding this comment.
im not sure what you mean. the units are shown in the duration displayed. i added comments in the code for clarification.
i also updated the code to order peers by oldest connection and get the id also from rpc.
mtsitrin
reviewed
May 12, 2024
| } | ||
|
|
||
| // ShowNodeIDCmd dumps node's ID to the standard output. | ||
| var ShowP2PInfoCmd = &cobra.Command{ |
There was a problem hiding this comment.
if all it does is calling rpc.NetInfo than the implementation is redundant
it should be implemented on the rollapp/RDK similar to
func getNodeStatus(clientCtx client.Context) (*coretypes.ResultStatus, error) {
node, err := clientCtx.GetNode()
if err != nil {
return &coretypes.ResultStatus{}, err
}
return node.Status(context.Background())
}
but just calling node.NetInfo
There was a problem hiding this comment.
got it. implemented in the rdk in dymensionxyz/dymension-rdk#420
|
closing pr, since logic has been moved to rdk in dymensionxyz/dymension-rdk#420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
Close #798
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: