Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(submission): Added another loop to not revert to submission while waiting for batch #840

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(submission): Added another loop to not revert to submission while waiting for batch #840

merged 1 commit into from
May 10, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix marked this pull request as ready for review May 10, 2024 09:10
@omritoptix omritoptix requested a review from a team as a code owner May 10, 2024 09:10
@omritoptix omritoptix changed the title fix(submission): Added another loop to not revert to submission while waiting. fix(submission): Added another loop to not revert to submission while waiting May 10, 2024
@omritoptix omritoptix changed the title fix(submission): Added another loop to not revert to submission while waiting fix(submission): Added another loop to not revert to submission while waiting for batch May 10, 2024
@omritoptix omritoptix merged commit 13f67dd into release/v1.1.1-hotfix-x May 10, 2024
3 of 5 checks passed
@omritoptix omritoptix deleted the omritoptix/hotfix-fix-submission-loop branch May 10, 2024 09:10
omritoptix added a commit that referenced this pull request May 10, 2024
@omritoptix
fix(submission): Added another loop to not revert to submission while…
6606d45 
… waiting for batch (#840)

(cherry picked from commit 13f67dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omritoptix