Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): pass metrics to mempool init #846

Merged
merged 1 commit into from
May 12, 2024

Conversation

artemijspavlovs
Copy link
Contributor

@artemijspavlovs artemijspavlovs commented May 12, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


this change passes the received metrics provider from function arguments down to dymint mempool creation. after enabling this, mempool size metric is available on the /metrics endpoint. Other metrics will come in a separate PR.

❯ curl localhost:2112/metrics | grep dymint
# TYPE dymint_mempool_size gauge
dymint_mempool_size 0

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner May 12, 2024 15:12
@artemijspavlovs artemijspavlovs self-assigned this May 12, 2024
@omritoptix omritoptix changed the title chore: use metrics from function arguments fix(metrics): use metrics from function arguments May 12, 2024
@omritoptix omritoptix changed the title fix(metrics): use metrics from function arguments fix(metrics): pass metrics to mempool init May 12, 2024
@mtsitrin mtsitrin merged commit 94267ae into main May 12, 2024
5 checks passed
@mtsitrin mtsitrin deleted the artemijspavlovs/enable-prometheus-metrics branch May 12, 2024 17:40
@artemijspavlovs artemijspavlovs linked an issue May 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mempool metrics
3 participants