Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(da): celestia height not updated when syncing #851

Merged
merged 1 commit into from
May 14, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented May 13, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #729

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner May 13, 2024 11:03
@srene srene self-assigned this May 13, 2024
@srene srene added bug Something isn't working C:da DA related labels May 13, 2024
@omritoptix omritoptix merged commit 491f16d into main May 14, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/729-update-celestia-syncing branch May 14, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C:da DA related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when syncing celestia client the information about initial height and end height is not updated in logs
2 participants