Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local pub sub): use error for subscription cancelled (instead of info) #853

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(local pub sub): use error for subscription cancelled (instead of info) #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion block/synctarget.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func (m *Manager) SyncTargetLoop(ctx context.Context) {
m.UpdateSyncParams(eventData.EndHeight)
m.SyncTargetDiode.Set(diodes.GenericDataType(&eventData.EndHeight))
case <-subscription.Cancelled():
m.logger.Info("syncTargetLoop subscription canceled")
m.logger.Error("syncTargetLoop subscription canceled")
return
}
}
Expand Down
2 changes: 1 addition & 1 deletion settlement/dymension/dymension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func (d *HubClient) PostBatch(batch *types.Batch, daClient da.Client, daResult *
return d.ctx.Err()

case <-subscription.Cancelled():
return fmt.Errorf("subscription cancelled: %w", err)
return fmt.Errorf("subscription cancelled")

case <-subscription.Out():
d.logger.Debug("Batch accepted", "startHeight", batch.StartHeight, "endHeight", batch.EndHeight)
Expand Down
2 changes: 1 addition & 1 deletion utils/event/funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func MustSubscribe(
case event := <-subscription.Out():
callback(event)
case <-subscription.Cancelled():
logger.Info(clientID + " subscription canceled")
logger.Error("subscription cancelled", "clientID", clientID)
return
}
}
Expand Down
Loading