Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): removes outdated syncTarget field #854

Merged
merged 29 commits into from
May 16, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented May 13, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #850

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt marked this pull request as ready for review May 13, 2024 13:49
@danwt danwt requested a review from a team as a code owner May 13, 2024 13:49
@omritoptix
Copy link
Contributor

@danwt conflicts

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 39.14%. Comparing base (851b312) to head (448db03).
Report is 33 commits behind head on main.

❗ Current head 448db03 differs from pull request most recent head 74ce466. Consider uploading reports for the commit 74ce466 to get more accurate results

Files Patch % Lines
block/synctarget.go 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   40.44%   39.14%   -1.31%     
==========================================
  Files         120      120              
  Lines       18935    18602     -333     
==========================================
- Hits         7659     7282     -377     
- Misses      10201    10281      +80     
+ Partials     1075     1039      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danwt danwt requested a review from mtsitrin May 16, 2024 09:45
@danwt danwt requested a review from mtsitrin May 16, 2024 10:21
@danwt danwt requested a review from mtsitrin May 16, 2024 12:49
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danwt you may wanna change the filename of synctarget

@mtsitrin mtsitrin merged commit 04b13a0 into main May 16, 2024
6 checks passed
@mtsitrin mtsitrin deleted the danwt/850-remove-syncTarget-field branch May 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/simplify syncTarget field on manager
4 participants