fix(da): full-nodes can sync from p2p while DA light client is down or out of sync #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mtsitrin
requested changes
May 15, 2024
|
conflicts @srene |
|
btw, solves #770? |
yes, the problem was coming from da stuck in the starting process when celestia was syncing meanwhile the node was starting to get batches. I opened a new issue for that, so i think we can close 770 |
|
Please do |
srene
force-pushed
the
srene/856-fullnode-dontwait-da
branch
from
83fcec0 to
50bec52
Compare
danwt
requested changes
May 15, 2024
srene
force-pushed
the
srene/856-fullnode-dontwait-da
branch
from
22f0caf to
09d08ae
Compare
mtsitrin
reviewed
May 16, 2024
mtsitrin
approved these changes
May 16, 2024
mtsitrin
requested changes
May 16, 2024
Co-authored-by: Daniel T <[email protected]>
srene
force-pushed
the
srene/856-fullnode-dontwait-da
branch
from
d020e95 to
31ab15b
Compare
Comment on lines
+612
to
+614
| go func() { | ||
| done <- rpc.Header.SyncWait(c.ctx) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
omritoptix
reviewed
May 18, 2024
| } | ||
|
|
||
| c.logger.Info("Celestia-node is synced.", "height", state.ToHeight) | ||
| go c.sync(rpc) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
omritoptix
approved these changes
May 18, 2024
omritoptix
pushed a commit
that referenced
this pull request
May 18, 2024
…r out of sync (#857) Co-authored-by: Daniel T <[email protected]>
This was referenced Jun 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
The main objective of this PR is the startup process for Celestia DA for full-nodes. With the modifications, full nodes will not wait for a DA to be in sync (or up) and it will do the syncing process in the background, while the full-node can start receiving and caching gossiped blocks from P2P. It also solves a nil pointer error that was happening when DA light finished syncing and a full-node was started when was not still in sync. Without the modifications of this PR, a node could start receiving gossiped blocks, but everything received while DA was syncing was disregarded because the block manager was not started, waiting for the celestia light node to finish the syncing process.
Opening a pull request should be able to meet the following requirements
Close #856 , #799 , #770
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: