feat(p2p): add p2p advertising option #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srene
changed the base branch from
srene/798-command-p2p-status
to
srene/797-change-p2p-options
srene
changed the title
mtsitrin
reviewed
May 15, 2024
mtsitrin
previously approved these changes
May 15, 2024
danwt
requested changes
May 15, 2024
config/defaults.go
Outdated
| @@ -42,6 +42,7 @@ func DefaultConfig(home, chainId string) *NodeConfig { | |||
| BootstrapTime: 30 * time.Second, | |||
| ListenAddress: DefaultListenAddress, | |||
| BootstrapNodes: "", | |||
| Advertising: true, | |||
There was a problem hiding this comment.
Would prefer Advertise or AdvertisingEnabled as a name, ditto for p2p.go
srene
force-pushed
the
srene/797-change-p2p-options
branch
from
23a92c0 to
3603b27
Compare
mtsitrin
dismissed stale reviews from danwt and themself
The base branch was changed.
omritoptix
pushed a commit
that referenced
this pull request
May 18, 2024
Co-authored-by: Michael Tsitrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
Close #
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: