Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(chart): switch from ingress annotation to ingressClassName #94

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

reg0bs
Copy link
Contributor

@reg0bs reg0bs commented Jan 22, 2025

The annotation kubernetes.io/ingress.class: alb is deprecated based on an error I got when trying to deploy:

helm install unguard . --values values.yaml --wait --namespace unguard --create-namespace
W0122 08:02:46.163224 663632 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

I've updated the specs accordingly so they include the supported ingressClassName.

@reg0bs reg0bs requested a review from a team as a code owner January 22, 2025 08:52
@W3D3
Copy link
Contributor

W3D3 commented Jan 24, 2025

Thanks for the contribution!
The build seems to be failing for unrelated reasons, but we are already looking into fixing this - will let you know once it is ready to rebase!

@W3D3
Copy link
Contributor

W3D3 commented Jan 28, 2025

@reg0bs We just fixed the build with #96 , you can rebase to fix the pipeline :)

Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@W3D3 W3D3 merged commit b450d8c into dynatrace-oss:main Feb 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants