Skip to content

fix: windows dll linker with same flags as posix

Sign in for the full log view
GitHub Actions / cpplint completed Jan 12, 2025 in 0s

reviewdog [cpplint] report

reported by reviewdog 🐢

Findings (4)

src/winlinker.c|43| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
src/winlinker.c|46| Missing space after ; [whitespace/semicolon] [3]
src/winlinker.c|49| Missing space after ; [whitespace/semicolon] [3]
src/winlinker.c|51| Add #include for snprintf [build/include_what_you_use] [4]

Filtered Findings (0)

Annotations

Check warning on line 43 in src/winlinker.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/winlinker.c#L43

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
src/winlinker.c:43:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]

Check warning on line 46 in src/winlinker.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/winlinker.c#L46

 Missing space after ;  [whitespace/semicolon] [3]
Raw output
src/winlinker.c:46:  Missing space after ;  [whitespace/semicolon] [3]

Check warning on line 49 in src/winlinker.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/winlinker.c#L49

 Missing space after ;  [whitespace/semicolon] [3]
Raw output
src/winlinker.c:49:  Missing space after ;  [whitespace/semicolon] [3]

Check warning on line 51 in src/winlinker.c

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] src/winlinker.c#L51

 Add #include <cstdio> for snprintf  [build/include_what_you_use] [4]
Raw output
src/winlinker.c:51:  Add #include <cstdio> for snprintf  [build/include_what_you_use] [4]