feat/oauth #69
feat/oauth #69
Conversation
puria
commented
Feb 9, 2024
puria
commented
- feat: first draft Slangroom plugin for OAuth
- refactor: first draft using AuthorizationCodeModel
- refactor: generate AccessToken with JWK as input
- feat: create AuthorizationCode with default authentication
|
@puria the statement here: https://github.com/dyne/slangroom/blob/feat/oauth/pkg/oauth/test/e2e.ts#L55 Takes 4 objects as input: 3 out of 4 "body", "headers" and "client" come from the client request at the same time. Should we create a scheme in Slangroom that packages those 3, in order to shorten the Slangroom statement? We need to investigate if this would impact interoperability. |
pkg/oauth/src/authenticateHandler.ts
Outdated
| if (!options.model) { | ||
| throw new InvalidArgumentError('Missing parameter: `model`'); | ||
| } | ||
|
|
||
| if (!options.model.getAccessToken) { | ||
| throw new InvalidArgumentError('Invalid argument: model does not implement `getAccessToken()`'); | ||
| } | ||
|
|
||
| if (options.scope && undefined === options.addAcceptedScopesHeader) { | ||
| throw new InvalidArgumentError('Missing parameter: `addAcceptedScopesHeader`'); | ||
| } | ||
|
|
||
| if (options.scope && undefined === options.addAuthorizedScopesHeader) { | ||
| throw new InvalidArgumentError('Missing parameter: `addAuthorizedScopesHeader`'); | ||
| } | ||
| // console.log(options.scope && !options.model.verifyScope) = undefined but pass the check | ||
| if (options.scope && !options.model.verifyScope) { | ||
| throw new InvalidArgumentError('Invalid argument: model does not implement `verifyScope()`'); | ||
| } |
There was a problem hiding this comment.
Bravo good, job. Nice error description, user oriented. Maybe you also want to look at Some[1] or Any functions when you want to check more than one values at once (like 2 or 3 if's it's okay in this case)
[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some
