Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-connectionId-userId): WEB-3445 added support for custom connectionId, userId along with some fixes #10

Merged
merged 7 commits into from
Dec 9, 2023

Conversation

ravindra-dyte
Copy link
Contributor

@ravindra-dyte ravindra-dyte commented Dec 8, 2023

WEB-3445

  1. Added support for passing connectionId and speakerUserId.
  2. Fixed device audio sampling issues where devices that could only support lower sample rate were not working.
  3. Refactored the SDK code to remove non-essential code from the actual SDK build.
  4. Added temp fix for Stale AudioContext & processor issue where the old processor is still running and feeding Symbl with audio buffers with all zero values (silent track). This was causing Symbl transcriptions to not show in case of device switch.
  5. Updated README for new fields. Added a quick way to test locally.

Copy link

github-actions bot commented Dec 8, 2023

If a Release job is running on staging, wait for it to complete before merging this PR.

Copy link

github-actions bot commented Dec 8, 2023

If a Release job is running on staging, wait for it to complete before merging this PR.

Copy link

github-actions bot commented Dec 8, 2023

If a Release job is running on staging, wait for it to complete before merging this PR.

Copy link

github-actions bot commented Dec 8, 2023

If a Release job is running on staging, wait for it to complete before merging this PR.

@palashgo palashgo merged commit b67a38a into main Dec 9, 2023
3 checks passed
@palashgo palashgo deleted the feat/WEB-3445-symbl-custom-connectionId-userId branch December 9, 2023 07:34
Copy link

deployte-bot bot commented Dec 9, 2023

The PR wasn't made to a repo handled by gitops, I will not make an update on the gitops repo.

Copy link

github-actions bot commented Dec 9, 2023

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants