Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posts: Add GSoC #18

Merged
merged 3 commits into from
Jul 20, 2017
Merged

posts: Add GSoC #18

merged 3 commits into from
Jul 20, 2017

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jul 11, 2017 •
edited
Loading

Signed-off-by: Ce Gao [email protected]

Related issue #0

Post info

  • Title: Google Summer of Code 申请指南
  • Author: gaocegege
  • License: default
  • Estimate finish time: Already

@gaocegege
posts: Add GSoC
89cb4b9 
Signed-off-by: Ce Gao <[email protected]>
@gaocegege
Copy link
Member Author

gaocegege commented Jul 11, 2017 •
edited
Loading

CI fails because of the wrong version of golang. It was fixed in #17

@at15
Copy link
Member

at15 commented Jul 11, 2017

@gaocegege mind update the PR description? the example content should not be there 😄

@gaocegege
Copy link
Member Author

Done

at15
at15 reviewed Jul 12, 2017
View reviewed changes
source/google_summer_of_code_申请指南.md

## 结语

这是一篇摸鱼作，希望能够对各位有所帮助。其实大家在选择开源社区的时候可以多问问有经验的人，尽可能选择一个友好的社区作为开始，这样会在开源的路上走的远一点。。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉应该说一些比较友好的社区吧，以及贡献的注意事项 (埋灰的 dyweb/mos#18

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那要拖一段时间了。。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我 LGTM 打到一半发现 title 变成 WIP 了.... 感觉还是先发了吧, WIP 就不知道什么时候了 ....

@gaocegege gaocegege changed the title posts: Add GSoC WIP: posts: Add GSoC Jul 12, 2017
@at15
Copy link
Member

at15 commented Jul 12, 2017 •
edited
Loading

LGTM

LGTM

Approved with PullApprove

@at15
Copy link
Member

at15 commented Jul 16, 2017

cc @arrowrowe @ComMouse need another LGTM from any of you

@arrowrowe
Copy link
Member

arrowrowe commented Jul 16, 2017 •
edited by at15
Loading

我没啥意见, 上面的错别字改下就好了...

LGTM:sheep:

Approved with PullApprove

arrowrowe
arrowrowe approved these changes Jul 16, 2017
View reviewed changes
source/google_summer_of_code_申请指南.md Outdated
tags:
- "Google Summer of Code"
- "申请指南"
preview: "本文的受众主要是想在暑假找点事情做，挣点外块的同学，亦或是想积累一下参与真实软件开发经验的同学。"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 外快?

@at15
Copy link
Member

at15 commented Jul 16, 2017

@gaocegege it seems you need to merge it manually due to CI failing ....

at15
at15 approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@at15 at15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... e, dual approve

@gaocegege
Copy link
Member Author

OK

@gaocegege
gsoc: Fix typo
4f86a08 
Signed-off-by: Ce Gao <[email protected]>
@gaocegege
Copy link
Member Author

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "code-review/pullapprove" is expected.
To github.com:dyweb/blog.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to '[email protected]:dyweb/blog.git'

@gaocegege gaocegege changed the title WIP: posts: Add GSoC posts: Add GSoC Jul 17, 2017
@gaocegege
Copy link
Member Author

=。= 原来改标题就好了

@gaocegege
Copy link
Member Author

修改了 typo，要重新 review。。

@at15
Copy link
Member

at15 commented Jul 17, 2017 •
edited
Loading

LGTM /w\

Approved with PullApprove

@ComMouse
Copy link
Member

ComMouse commented Jul 20, 2017 •
edited by at15
Loading

LGTM

Approved with PullApprove

@at15
Copy link
Member

at15 commented Jul 20, 2017

LGMT

@at15
Copy link
Member

at15 commented Jul 20, 2017 •
edited
Loading

LGTM

Approved with PullApprove

@at15 at15 merged commit c418ac5 into master Jul 20, 2017
@at15
Copy link
Member

at15 commented Jul 20, 2017 •
edited
Loading

oops, forgot to build the html .... @gaocegege

@ComMouse ComMouse mentioned this pull request Jul 21, 2017
Merged
@at15 at15 deleted the gsoc branch September 2, 2017 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComMouse ComMouse ComMouse approved these changes

@at15 at15 at15 approved these changes

@arrowrowe arrowrowe arrowrowe approved these changes

Assignees
No one assigned
Labels
area/event area/oss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaocegege @at15 @arrowrowe @ComMouse