fix: fold empty within condition to false/true

dzikoysk · Oct 11, 2024 · a98705d · a98705d
1 parent 56c2d47
commit a98705d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/sqiffy/src/main/kotlin/com/dzikoysk/sqiffy/dsl/generator/dialects/GenericQueryGenerator.kt b/sqiffy/src/main/kotlin/com/dzikoysk/sqiffy/dsl/generator/dialects/GenericQueryGenerator.kt
@@ -147,7 +147,11 @@ abstract class GenericQueryGenerator : SqlQueryGenerator {
             }
             is WithinCondition<*, *> -> {
                 when {
-                    expression.values.isEmpty() -> GeneratorResult(query = "TRUE")
+                    expression.values.isEmpty() ->
+                        when (expression.type) {
+                            WithinType.IN -> GeneratorResult(query = "FALSE")
+                            WithinType.NOT_IN -> GeneratorResult(query = "TRUE")
+                        }
                     expression.values.size == 1 ->
                         createExpression(
                             allocator,