Generalize the plugin to make it easier to add new providers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And from the `AuthCompletionHandler` interface. Instead, wrap all references into the `AuthCompletionHandler` implementation Testing done: - initial signin + refresh both work
And from the interface to `GoogleAccountManagerAuth`. All references are only in the implementation.
shankari
added a commit
to shankari/cordova-server-sync
that referenced
this pull request
Aug 20, 2017
Similar to e-mission/cordova-server-communication@f311677, Changes corresponding to to e-mission/cordova-jwt-auth#18 In particular, changes e-mission/cordova-jwt-auth@c84b93e and e-mission/cordova-jwt-auth@eddfe9b
|
Related communication changes |
And switch the existing google sign-in auth completion handler to implement that protocol. All external references now use the factory directly. Almost there!
And switch the existing google sign-in auth completion handler to implement that protocol. All external references now use the factory directly. Almost there! These are the android changes
shankari
added a commit
to shankari/e-mission-data-collection
that referenced
this pull request
Aug 20, 2017
From the specific google implementation used earlier This corresponds to the changes in e-mission/cordova-jwt-auth#18
The main difference is that instead of passing the activity (on android) or the viewcontroller (on iOS), we pass the plugin as an argument to the token creator, *for the signIn case*. For anything other than the sign in case, we don't actually need any UI stuff, so this allows us to avoid the awkward instanceof check for activity on android, and the equally awkward need to remember to set the view controller on iOS. And passing in the plugin also allows us to set activity result callback from the google-specific implementation instead of the generic plugin (we may not use the activity callbacks for all implementations) and makes it easier to implement the dev implementation that needs to execute javascript. Includes minor fix to the way that files are copied over.
…implementation `AuthCompletionHandler` is a really generic name for something that is really the google-specific implementation. Rename to match the android code, specially when we're reinstalling the plugin anyway
We renamed `AuthCompletionHandler` to `GoogleSigninAuth` in f9b82d8. This fixes the code to return use it properly. Checking in as separate commit to capture the `git mv` properly
obvs I need the header, because otherwise the return type of `getInstance` is unknown. Was removed in a2f008a
…llback In that case, `tokenCreator` is null and we shouldn't crash. Instead, we can just ignore the call to the custom URL.
In this, the user simply enters their email address. If the email address matches one that was used to load data before this, the account is re-used, which makes it easier to review and re-test data. It also ensure that sessions are maintained across app restarts without logging in every time, which makes debugging a lot easier. And finally, it is an example of a javascript-based auth callback, which should make it much easier to integrate with other auth systems if they don't already have nice libraries to do it for us. NOTE: the javascript stuff is extremely kludgy and ugly-looking, and I will clean it up shortly after some more experimentation.
This should have been part of 4d5eecc but I forgot :(
- Unifies the code between ios and android - Makes it easier to see (wrapping everything in " for the code strings and then ' for the strings in the code was getting confusing) - This also makes it easier to see multi-line code - We can also attach the debugger to the function, which might be useful as this gets more complex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for two use cases:
In particular, we want to support: