Fix problems discovered while using the code in the emission app #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in code that has since been moved to AuthCompletionHandler.
which is not really part of this package
Rename the javascript interface to match the plugin. Note that this interface does not actually invoke the corresponding native code. That is because javascript support for http is good, arguably better than native, so it is unclear why we would revert to native anyway.
… library We should really upgrade this at some point, but that point is not now
Everything else worked right out of the box
shankari
added a commit
that referenced
this pull request
Feb 5, 2016
Fix problems discovered while using the code in the emission app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.