Switch to new authentication library and sign in screen from google #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are currently at version 1, I will lazily start versioning our native plugins so that we have a better sense of how we are making changes
Including the headers as part of this project leads to compile errors caused by duplicate definitions. This fixes it. See google/gtm-session-fetcher#82 for more details
This changes the communicationhelper to use the new form of the `AuthCompletionHandler` (change in e-mission/cordova-jwt-auth@cfa5457) Also removes the obsolete callbacks which are not invoked any more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the changes required by
https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html
Most of the changes are in
e-mission/cordova-jwt-auth#13
The changes here merely adapt to those changes.