Restore hardcoded jwt #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code The original idea was that the javascript implementation of the code would just use the javascript HTTP implementations, and make a call to the native code to get the JWT. As we can saw, this does not refresh the token correctly if it is expired, which is why we went back to the old hardcoded method. But then if we want to use the old hardcoded method from javascript, we need to make calls back to native code. This change implements plugin interfaces on both ios and android that make the appropriate calls to the native code, and change the javascript to call it appropriately. This has not yet been tested, but let's get an initial version checked in.
The iOS code still doesn't actually work. So there's at least one more checkin coming in.
Basically, if the currAuth is NULL, then we read it from the keychain. But with the previous structure, after reading it, we just exit since everything else was in a giant else. Now, once we read the currAuth, we use it in the rest of the code. Wow. Simple restructuring. Much working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.