Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to set the HasRequestedNotificationPermission #242

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

shankari
Copy link
Contributor

@shankari shankari commented Oct 9, 2024

If it is not set and the user has consented
This fixes
e-mission/e-mission-docs#1094 (comment)

@shankari
Copy link
Contributor Author

shankari commented Oct 9, 2024

@JGreenlee I am almost out of battery; but you can take a look at this

Copy link
Contributor

@JGreenlee JGreenlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If it is not set and the user has consented
This fixes
e-mission/e-mission-docs#1094 (comment)

Testing done:

```
$ npx cordova build ios
** BUILD SUCCEEDED **
```
@shankari shankari force-pushed the store-notification-request branch from 3a7b6b4 to 7b0120f Compare October 9, 2024 21:07
@shankari shankari merged commit 06a90be into e-mission:master Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants