Update README.md #31
Open
Update README.md #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified what the eval_folder is and added windows versions of some commands
shankari
requested changes
Jun 8, 2022
Comment on lines
+18
to
+22
| In windows command prompt use: | ||
|
|
||
| ``` | ||
| > set EMISSION_SERVER_HOME=<path_to_emission_server_repo> | ||
| ``` |
There was a problem hiding this comment.
Do we have to support windows? We are not testing the windows codepaths regularly, and I am concerned that this will just bitrot and then we have to debug it all over again. Can we at least indicate that windows is unsupported and people are using it at their own risk?
There was a problem hiding this comment.
@allenmichael099 are you planning to resolve this so that I can merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified what the eval_folder is and added windows versions of some commands