Fit and finish fixes (logo + enabling more controls) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Download JSON dump (item 7 on Ipsita's list) - Allow medium accuracy (since there might be concerns about the power drain) - Disable "share" since the current text is not valid, and I don't know what the new text is
|
gonna wait a bit to see if @deepalics0044 is going to review this - making native code changes in the interim. |
|
No reviews forthcoming, merging now... |
|
deployed, should be live in ~ 10 mins |
shankari
added a commit
to shankari/e-mission-data-collection
that referenced
this pull request
Mar 28, 2019
Found while testing e-mission/e-mission-phone#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done - please see attached video (sorry it's in French, I was testing e-mission/e-mission-docs#333 yesterday and didn't have time to reset). But at least now you know how it works if somebody does have their phone set to a different language (Kannada?) :)
test_fit_and_finish_changes.mp4.gz
List of tests:
HIGH_ACCURACYBALANCED_POWER_ACCURACYHIGH_ACCURACY