Backwards compat changes to ensure that all tokens start with the study name #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until we actually go through and add a name to the survey spec We fill this in both on download and on load from disk
If we have a token that does not start with the study prefix, add it and re-save. This ensures that as the app is upgraded, all the tokens will be upgraded, and we can fix the server side tokens later. Testing done: - Logged in with an old-style token Initial login was as expected ``` 2022-07-10 21:25:09,655:DEBUG:123145355665408:Using the skip method to verify id token user-0 of length 6 2022-07-10 21:25:09,657:DEBUG:123145355665408:retUUID = 802667b6-371f-45b2-9c7a-bb051244836a ``` Then went to the control screen, which reset the token to nrelop_dev_user-0 ``` user email = user-0 index.html:154 DEBUG:Found old style token, after prepending nrelop_dev new token is nrelop_dev_user-0 ``` And we logged in after stripping the value ``` 2022-07-10 21:49:42,398:DEBUG:123145437908992:retUUID = None 2022-07-10 21:49:42,398:DEBUG:123145437908992:token nrelop_dev_user-0 is valid, but no account found. stripping out study name and retrying... 2022-07-10 21:49:42,398:DEBUG:123145437908992:study prefix is nrelop_dev 2022-07-10 21:49:42,398:DEBUG:123145437908992:After stripping out nrelop_dev, token is user-0 ``` Then updated the server token ``` 2022-07-10 21:52:58,581:DEBUG:123145422143488:Using the skip method to verify id token nrelop_dev_user-0 of length 17 2022-07-10 21:52:58,583:DEBUG:123145422143488:retUUID = .... ``` Login with a new token works as always ``` 2022-07-10 22:08:17,604:DEBUG:123145406377984:Using the skip method to verify id token nrelop_dev_bkR1arZm6mKw6Fym of length 27 2022-07-10 22:08:17,609:DEBUG:123145406377984:retUUID = 93ca26ce-8d8a-4d45-a41d-c6615ab791ab ```
|
Should we also ensure that any new tokens follow the correct format? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related server changes:
e-mission/e-mission-server@b73d671
e-mission/e-mission-server@0870760
e-mission/e-mission-server@6e9f4d2
Related PR comments:
e-mission/e-mission-docs#732 (comment)
Basically, we:
Once all the old style tokens are converted over, we can remove the final change.
Once we change the study config to include the name, and support config updates, we can remove the first change.