-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplified tests with two log messages for four test environments
The PATH values vary based on a user's local system and could have additional values which could fail the test in a local environment run without docker containers. Why do we even need the PATH, PYTHONPATH values in the assertion log messages. This is because we are printing the config in get_database.py which contains environment variables or config file values. Now, the question is why to print the entire set of values if we are only using DB_HOST, DB_RESULT_LIMIT? I am now printing only these values in the get_database.py. This has two benefits: - Allows to eliminate variable environment variables like PATH that might vary in local testing environments for every user. - Since PATH is no longer printed, helps avoid issue of 'apple security' values. - Helps reduce the number of log messages the 4 testing environments: local without docker, local with docker, CI/CD without docker, CI/CD with docker. The two docker environments have the same log message; similarly for the two non-docker environments. Thus we only need two log messages in the assertion tests.
- Loading branch information
Mahadik, Mukul Chandrakant
authored and
Mahadik, Mukul Chandrakant
committed
Aug 26, 2024
1 parent
1a13a49
commit 0efbdc8
Showing
2 changed files
with
9 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters