Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from pie charts to 100% stacked bar chart #123
Change from pie charts to 100% stacked bar chart #123
Changes from all commits
581b492
d6f1b82
5ddc396
1165562
2e9ad7d
a55e9f6
7e71308
45db963
ec9037b
ebeb9dd
a1283bb
441019c
e53c0cc
eb3dcfc
e582011
5fedbb0
f31e43e
7b6cef2
428982c
119d707
1c5e00a
4d58d4c
7f31c5d
3388258
11345f6
2f7b0da
c17027d
5d83605
f91f379
339f0cd
1cc1254
c2c0576
c639d89
687633f
66cb274
ddcfb1c
a95225a
cad3b1d
328c185
07b08c8
eed9a0e
eb83f5c
ce3e38d
c3a7273
ef5574f
4c8eb68
41324d2
90e2bf9
052fb54
77e963d
6718f5f
7fa150e
1b9a15c
7e4d3aa
2e84f41
4112448
64abfb3
a9b2fa3
ac7475d
5aafc02
87289ab
2bae83c
e97c20b
b554005
8450622
01cadb4
2819568
d033234
067e242
8e7292a
4542530
29b60d4
66b2397
376e064
d5c15bd
59236a1
21716f8
ae9c309
976c636
5b82f6e
d3e531d
64c02e4
cda15cc
f6c7144
d354641
b5da35b
b33426e
4dd2f8f
30b7f68
bfba1f1
ba1c038
531e510
541a973
9270ea9
310f36e
6a3684b
9954f40
98eabec
4b1a6dc
4816be9
fbf8494
b126cb3
259ee32
e4a81a1
a6535a7
1f4259a
d03357a
4c8e726
cee1111
cc6c436
d25b3b5
e4cad01
432c5ec
e004a7d
df92dfb
753331a
a569ead
78c724e
90957da
c3fc043
0766b2e
b0030aa
dcf4290
96bd2fe
bca500f
e583900
4eb6f8a
00cd1de
59cd9b2
e627a86
deccaa8
ed835a5
277e4f8
f785d59
625a65f
bf09575
874108c
ccb7126
de6f326
6e6936a
cac7b7f
8ea9e15
477b213
f993363
dcfe978
4bfe65f
f9e2cde
6749182
a02bb8d
de9b086
b796302
d993181
fa0da1f
0cc2cc8
37dc0aa
44bbb03
8b918aa
704df5a
a83e15d
dde65d0
d5d1bff
16b389d
d8e73a6
3e0c2b2
46e3a4a
fca63a3
e4bd690
7f8ad02
d00faf1
9b5bd1a
50d38ce
179dd25
893f69d
4f1c385
12b00e3
89ff25d
ffbde93
099c8bc
ffb3d81
013ca55
f7f3590
41a5fde
271b35f
996ba7d
71c2353
008d8a9
ce6f527
8410d33
d84833e
a22915f
3542105
6b4edf1
fd0693b
afda252
139a469
c16e4eb
4dbb34c
3ac8e0f
5e5bc42
1fcd100
238cf8e
d30503f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also be split when we move the mode specifc metrics back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both HTML and alt text? Now that we have the HTML file, I think we can get permission from Comms and remove alt-text in the next (label assist results incorporated) mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do have the same information, maybe if we implement the html as swapping in for the chart instead of being it's own grid element then we can move forward with it being a 1:1 swap for the alt text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the meeting discussion, we are keeping both HTML as well as alt text, while not modifying any the changes to showcase toggling between chart and html table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going to hold up the merge for this, but I am not sure why we only show the additional HTML for stacked metrics. Why would we not show it for all metrics? Again, with the screenreader use case, maybe the person wants to see/export data for other metrics as well